zaynt4606 commented on PR #2688:
URL: https://github.com/apache/celeborn/pull/2688#issuecomment-2487242010

   > Excuse me, I am a little confused about the concept of the two parameters 
of reserve. (`celeborn.worker.storage.disk.reserve.size` & 
`celeborn.worker.storage.disk.reserve.ratio`) Do these two parameters mean that 
the worker needs to ensure the remaining space on the disk, or that the size 
that needs to be reserved(not to be used) in the configured capacity? IIUC, 
suppose there is a 2T usable disk, the new started worker(total usage is 0) is 
configured with a capacity of 500g, and the reserve size is 500g. If it is the 
first explanation, it ensures there is always 500g free space on the disk, and 
the disk's actualUsableSpace is 500g, and if it is the second one, the 
actualUsableSpace is 0, the code seems to be this. Can someone help me answer 
this question in passing? Thanks in advance :)
   
   It should be 500g and reserve space should be relative to disk so there's a 
bug here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to