zaynt4606 commented on code in PR #2688:
URL: https://github.com/apache/celeborn/pull/2688#discussion_r1721198352
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/CelebornHashCheckDiskSuite.scala:
##########
@@ -91,9 +91,9 @@ class CelebornHashCheckDiskSuite extends SparkTestBase {
worker.storageManager.workingDirWriters.values().asScala.foreach { t =>
assert(t.size() === 0)
}
- // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=1000
+ // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=0
Review Comment:
> Shuffle keys are expired means that there is more space to use. I think
this UT looks confusing.
The usableSpace has to consider about the disk reserve size.The usableSpace
in the original code in this UT will both be configuredUsableSpace while in
this PR would be 0.
But whatever, the UT here has nothing to do with this PR.
So update this UT here with the reserve size = 0 would remain the previous
logic.
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/CelebornHashCheckDiskSuite.scala:
##########
@@ -91,9 +91,9 @@ class CelebornHashCheckDiskSuite extends SparkTestBase {
worker.storageManager.workingDirWriters.values().asScala.foreach { t =>
assert(t.size() === 0)
}
- // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=1000
+ // after shuffle key expired, diskInfo.actualUsableSpace will equal
capacity=0
Review Comment:
done and plz help review again😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
