s0nskar commented on code in PR #2925:
URL: https://github.com/apache/celeborn/pull/2925#discussion_r1849992599


##########
service/src/main/java/org/apache/celeborn/server/common/service/config/SystemConfig.java:
##########
@@ -69,10 +57,26 @@ public void setConfigs(Map<String, String> configs) {
     this.configs = configs;
   }
 
+  public void setConfigs(List<ClusterSystemConfig> configs) {
+    Map<String, String> newConfigs = new HashMap<>();
+    for (ClusterSystemConfig c : configs) {
+      newConfigs.put(c.getConfigKey(), c.getConfigValue());
+    }
+    this.configs = newConfigs;

Review Comment:
   Nice catch! Fixed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to