FMX commented on code in PR #2925:
URL: https://github.com/apache/celeborn/pull/2925#discussion_r1850267878
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/DynamicConfig.java:
##########
@@ -42,7 +42,7 @@
*/
public abstract class DynamicConfig {
private static final Logger LOG =
LoggerFactory.getLogger(DynamicConfig.class);
- protected Map<String, String> configs = new HashMap<>();
+ protected volatile Map<String, String> configs = new HashMap<>();
Review Comment:
This map won't be updated by multiple threads concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
