jiang13021 commented on code in PR #2979:
URL: https://github.com/apache/celeborn/pull/2979#discussion_r1875625228
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -293,14 +293,15 @@ public void flush(boolean finalFlush, boolean fromEvict)
throws IOException {
// read flush buffer to generate correct chunk offsets
// data header layout (mapId, attemptId, nextBatchId, length)
if (numBytes > chunkSize) {
- ByteBuffer headerBuf = ByteBuffer.allocate(16);
+ ByteBuffer headerBuf =
ByteBuffer.allocate(PushDataHeaderUtils.BATCH_HEADER_SIZE);
Review Comment:
If a worker receives a data buffer from an old version client, we will check
the checksum flag in the highest bit of batchId for compatibility. Similarly,
if the data comes from an unsupported engine's client but follows the old
version data header layout, it will also be compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
