jiang13021 commented on code in PR #2979: URL: https://github.com/apache/celeborn/pull/2979#discussion_r1875639620
########## common/src/main/java/org/apache/celeborn/common/util/PushDataHeaderUtils.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.celeborn.common.util; + +import java.util.zip.CRC32; + +import org.apache.celeborn.common.unsafe.Platform; + +public class PushDataHeaderUtils { + // Data Header Layout: + // | mapId (4 bytes) | + // | attemptId (4 bytes) | + // | batchId with checksum flag (4 bytes) | + // | length with checksum length (4 bytes) | + // | checksum (4 bytes) | + // + // Fields description: + // - mapId: Unique identifier for the map (4 bytes) + // - attemptId: Identifier for the attempt (4 bytes) + // - batchId with checksum flag: + // -- checksum flag: 1 bit (indicates if batchId has a checksum) + // -- batchId: 31 bits (always positive when represented as an integer) + // - length with checksum length: total length of the data + 4 bytes for checksum + // - checksum: Always positive integer (4 bytes) + public static final int BATCH_HEADER_SIZE = 5 * 4; + public static final int BATCH_HEADER_SIZE_WITHOUT_CHECKSUM = BATCH_HEADER_SIZE - 4; + public static final int MAP_ID_OFFSET = Platform.BYTE_ARRAY_OFFSET; + public static final int ATTEMPT_ID_OFFSET = Platform.BYTE_ARRAY_OFFSET + 4; + public static final int BATCH_ID_OFFSET = Platform.BYTE_ARRAY_OFFSET + 8; + public static final int LENGTH_OFFSET = Platform.BYTE_ARRAY_OFFSET + 12; + public static final int CHECKSUM_OFFSET = Platform.BYTE_ARRAY_OFFSET + 16; + public static final int POSITIVE_MASK = 0x7FFFFFFF; + public static final int HIGHEST_1_BIT_FLAG_MASK = 0x80000000; Review Comment: Worker will check the checksum flag in the highest bit of batchId for compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
