pan3793 commented on code in PR #2979:
URL: https://github.com/apache/celeborn/pull/2979#discussion_r1889726337
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4113,6 +4116,14 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefault(0)
+ val CLIENT_PUSH_CHECKSUM_HEADER_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.client.push.checksum.header.enabled")
Review Comment:
it's not necessary to expose implementation details in the user-oriented
configuration name. storing checksum in the header, body, or tail does not
matter to the functionality
```suggestion
buildConf("celeborn.client.push.checksum.enabled")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
