codenohup commented on PR #3012: URL: https://github.com/apache/celeborn/pull/3012#issuecomment-2553488532
Hi, @SteNicholas This PR LGTM, but I have a minor question. It seems that the decision to fall back to the built-in shuffle is based on `job` granularity rather than `Shuffle` granularity. I think it would be beneficial to have a fallback count metric that reflects `job` granularity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
