FMX commented on code in PR #3012:
URL: https://github.com/apache/celeborn/pull/3012#discussion_r1891892222
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/fallback/ShuffleFallbackPolicyRunner.java:
##########
@@ -32,7 +32,7 @@ public class ShuffleFallbackPolicyRunner {
private static final List<ShuffleFallbackPolicy> FALLBACK_POLICIES =
ShuffleFallbackPolicyFactory.getShuffleFallbackPolicies();
- public static boolean applyFallbackPolicies(
+ public static Optional<ShuffleFallbackPolicy> applyFallbackPolicies(
Review Comment:
I think this function name can be changed into `getActiveFallbackPolicy` to
match its logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
