HolyLow commented on code in PR #3042: URL: https://github.com/apache/celeborn/pull/3042#discussion_r1900887598
########## cpp/celeborn/protocol/TransportMessage.h: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <folly/io/Cursor.h> +#include <string> + +#include "celeborn/memory/ByteBuffer.h" +#include "celeborn/proto/TransportMessagesCpp.pb.h" + +namespace celeborn { Review Comment: I think nested namespace is not that necessary. The nested namespace is to avoid naming conflict within the celebornCpp project (as the celebornCpp project is already protected in namespace celeborn and won't conflict with other projects), which is unlikely to happen as the celebornCpp is only for client side and is not for too much complexity. In contrast, a flat celeborn namespace would make it easier to use. But nested namespace would offer more symbol isolation, and if you insist, I could refactor the code of course. But should we refactor all the modules, including memory, utils, conf, etc? Looking forward to your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
