HolyLow commented on code in PR #3042: URL: https://github.com/apache/celeborn/pull/3042#discussion_r1901469564
########## cpp/celeborn/protocol/CMakeLists.txt: ########## @@ -12,7 +12,7 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -add_library(protocol PartitionLocation.cpp) +add_library(protocol PartitionLocation.cpp TransportMessage.cpp) Review Comment: It seems that only the proto module explicitly declares STATIC, and other modules don't declare it. So this is consistent to other modules. Yet adding the STATIC declaration brings no harm, so this cmakelist is refactored as requested. We could refactor the makelists in the following commit to add the STATIC to all makelists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
