zaynt4606 commented on code in PR #3059:
URL: https://github.com/apache/celeborn/pull/3059#discussion_r1912731738
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala:
##########
@@ -439,12 +447,14 @@ private[deploy] class Controller(
return
} else if (commitInfo.status == CommitInfo.COMMIT_INPROCESS) {
logInfo(s"$shuffleKey CommitFiles inprogress, wait for finish")
- // should not use commitThreadPool in case of block by commit files.
- waitThreadPool.submit(new Runnable {
- override def run(): Unit = {
- waitForCommitFinish()
- }
- })
+ // replace ThreadPool to avoid blocking
+ shuffleCommitTime.putIfAbsent(
+ shuffleKey,
+ JavaUtils.newConcurrentHashMap[Long, (Int, RpcCallContext)]())
+ val epochWaitTimeMap = shuffleCommitTime.get(shuffleKey)
+ epochWaitTimeMap.synchronized {
Review Comment:
Done~
Read and write security of epoch in epochWaitTimeMap is guaranteed by
commitInfo's lock so the lock of epochWaitTimeMap is needless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
