zaynt4606 commented on code in PR #3059:
URL: https://github.com/apache/celeborn/pull/3059#discussion_r1912732744
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala:
##########
@@ -730,6 +740,44 @@ private[deploy] class Controller(
}
}
+ private def checkCommitTimeout(shuffleCommitTime: ConcurrentHashMap[
Review Comment:
Updated with UT
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala:
##########
@@ -730,6 +740,44 @@ private[deploy] class Controller(
}
}
+ private def checkCommitTimeout(shuffleCommitTime: ConcurrentHashMap[
+ String,
+ ConcurrentHashMap[Long, (Int, RpcCallContext)]]): Unit = {
+ val delta = 100
+ val shuffleCommitTimeout = conf.workerShuffleCommitTimeout
Review Comment:
Done~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
