pan3793 commented on code in PR #3196:
URL: https://github.com/apache/celeborn/pull/3196#discussion_r2024531388
##########
charts/celeborn/values.yaml:
##########
@@ -186,10 +186,17 @@ priorityClass:
# -- Specifies the integer value of this priority class, default is
Celeborn master value minus 1000
value: 999999000
-# -- Pod annotations
-podAnnotations: {}
-# key1: value1
-# key2: value2
+master:
+ # -- Pod annotations for Celeborn master pods.
+ annotations:
Review Comment:
> If you cannot accept breaking changes, I can also make the Helm chart
backward compatible by adding extra templating logic, which may introduce some
complexity.
It depends on the maturity of the component. The Helm chart was added for a
long time, but has not had an official release yet. I personally would treat it
as an unstable feature, and I also have done bunches of modifications in our
internal branch. If other core members also treat it as unstable, then we just
need to
> mentioning the breaking changes in release notes with some general words
instead of documenting every change or keeping backward compatible by
introducing extra complexity.
But if someone thinks Helm chart backward compatibility is important, we
should be careful about breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
