ChenYi015 commented on code in PR #3196:
URL: https://github.com/apache/celeborn/pull/3196#discussion_r2030368322
##########
charts/celeborn/values.yaml:
##########
@@ -186,10 +186,17 @@ priorityClass:
# -- Specifies the integer value of this priority class, default is
Celeborn master value minus 1000
value: 999999000
-# -- Pod annotations
-podAnnotations: {}
-# key1: value1
-# key2: value2
+master:
+ # -- Pod annotations for Celeborn master pods.
+ annotations:
Review Comment:
@pan3793 We have started a discussion within the DingDing user group on
whether to rename the values, which may introduce breaking changes. Most of the
maintainers think it is acceptable since we have not published an official Helm
chart for out-of-box usage. Maybe we can continue on merging this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
