FMX commented on code in PR #3109:
URL: https://github.com/apache/celeborn/pull/3109#discussion_r2041353296
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java:
##########
@@ -606,4 +608,22 @@ public static void
invalidateSerializedGetReducerFileGroupResponse(Integer shuff
return null;
});
}
+
+ public static void addWriterShuffleIdsToBeCleaned(
+ LifecycleManager lifecycleManager, String appShuffleIdentifier) {
+ FailedShuffleCleaner.setLifecycleManager(lifecycleManager);
+ FailedShuffleCleaner.addShuffleIdToBeCleaned(appShuffleIdentifier);
+ }
+
+ public static void addShuffleIdRefCount(
+ LifecycleManager lifecycleManager, int celebornShuffeId, String
appShuffleIdentifier) {
Review Comment:
Here is a typo. celebornShuffeId --> celebornShuffleId
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -165,6 +178,19 @@ private void initializeLifecycleManager(String appId) {
lifecycleManager.registerInvalidatedBroadcastCallback(
shuffleId ->
SparkUtils.invalidateSerializedGetReducerFileGroupResponse(shuffleId));
}
+ if (lifecycleManager.conf().clientFetchCleanFailedShuffle()) {
Review Comment:
These lines are duplicates of lines 159~172.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
