CodingCat commented on code in PR #3109:
URL: https://github.com/apache/celeborn/pull/3109#discussion_r2045877447
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -150,13 +150,26 @@ private void initializeLifecycleManager(String appId) {
lifecycleManager.registerShuffleTrackerCallback(
shuffleId ->
SparkUtils.unregisterAllMapOutput(mapOutputTracker, shuffleId));
-
if
(celebornConf.clientAdaptiveOptimizeSkewedPartitionReadEnabled()) {
lifecycleManager.registerCelebornSkewShuffleCheckCallback(
SparkUtils::isCelebornSkewShuffleOrChildShuffle);
}
}
+ if (lifecycleManager.conf().clientFetchCleanFailedShuffle()) {
+ lifecycleManager.registerValidateCelebornShuffleIdForCleanCallback(
Review Comment:
yes, you are right, added the check to ensure that stage rerun is enabled
when this feature is turned on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
