ashangit opened a new pull request, #3237:
URL: https://github.com/apache/celeborn/pull/3237

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] 
Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Add capability to set 
[PVC](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) as 
master and worker volumes 
   
   Also rely on [helm schema 
file](https://helm.sh/docs/topics/charts/#schema-files) to validate that volume 
type is within the authorised enum instead of relying on if-else-fail within 
the statefulset yaml file
   
   ### Why are the changes needed?
   
   Usage of 
[PVC](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) is a 
common pattern to assign storage volumes to POD within kubernetes
   Those [PVC](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) 
can be of different type (local storage, distant storage like 
[EBS](https://aws.amazon.com/ebs/)...)
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Added helm test and deployed a celeborn cluster in our kube infrastructure 
based on pvc for master and workers:
   ```
   volumes:
     master:
       - type: pvc
         mountPath: /mnt/disk1
         capacity: 10Gi
         storageClassName: gp3
     worker:
       - type: pvc
         mountPath: /mnt/disk1
         capacity: 2000Gi
         storageClassName: gp3
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to