Copilot commented on code in PR #3237:
URL: https://github.com/apache/celeborn/pull/3237#discussion_r2084148864
##########
charts/celeborn/templates/worker/statefulset.yaml:
##########
@@ -155,4 +153,19 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
terminationGracePeriodSeconds: 30
-
+ {{- if eq (include "celeborn.worker.withPvc" .) "true" }}
+ volumeClaimTemplates:
+ {{- range $index, $volume := .Values.volumes.worker }}
+ {{- if eq "pvc" $volume.type }}
Review Comment:
The pvc volumeClaimTemplates block does not incorporate the diskType field,
even though the values.yaml documentation indicates that diskType works with
both hostPath and pvc types. Consider clarifying whether diskType should be
used in the PVC configuration or update the documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
