turboFei commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2064371887
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/WorkerSource.scala:
##########
@@ -111,8 +111,12 @@ class WorkerSource(conf: CelebornConf) extends
AbstractSource(conf, Role.WORKER)
val applicationIds =
appActiveConnections.get(client.getChannel.id().asLongText())
Review Comment:
could you define a variable for `metricsLabelApplicationId`, and how about
return directly if `metricsLabelApplicationId` is false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
