onebox-li commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2084050342
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5594,6 +5597,16 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val METRICS_WORKER_APP_LEVEL_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.metrics.worker.appLevel.enabled")
+ .categories("metrics")
+ .doc("When true, enable worker application level metrics. Note:
applicationId is " +
+ "considered as a high cardinality label, be careful enabling it on
metrics systems " +
+ "that are not optimized for high cardinality columns.")
+ .version("0.6.0")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
Whether here need to retain the original behavior (default true)？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
