codenohup commented on code in PR #3239:
URL: https://github.com/apache/celeborn/pull/3239#discussion_r2068080441
##########
common/src/main/java/org/apache/celeborn/common/network/server/TransportChannelHandler.java:
##########
@@ -113,7 +113,7 @@ public void channelActive(ChannelHandlerContext ctx) throws
Exception {
ctx.executor()
.scheduleWithFixedDelay(
() -> {
- logger.debug("send heartbeat");
+ logger.debug("Send heartbeat to {}.",
ctx.channel().remoteAddress());
Review Comment:
`NettyUtils.getRemoteAddress(ctx.channel())`?
##########
common/src/main/java/org/apache/celeborn/common/network/server/TransportRequestHandler.java:
##########
@@ -95,6 +95,18 @@ public void handle(RequestMessage request) {
}
}
+ protected void processHeartbeat() {
+ try {
+ logger.trace("Process heartbeat from {}.",
NettyUtils.getRemoteAddress(channel));
+ respond(new Heartbeat());
+ } catch (Exception e) {
+ logger.error(
+ "Error while invoking handler#receive() on heartbeat from {}.",
Review Comment:
Confusing error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
