ashangit opened a new pull request, #3243:
URL: https://github.com/apache/celeborn/pull/3243

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] 
Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a 
faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Support all [default hadoop 
provider](https://github.com/apache/hadoop/blob/rel/release-3.3.6/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java#L563)
 for S3 authentication
   
   ### Why are the changes needed?
   
   As of now celeborn only support authentication based on ACESS/SECRET key 
while other authentication mechanism can be required (for ex. ENV var, relying 
on 
[AWS_CONTAINER_CREDENTIALS_RELATIVE_URI](https://docs.aws.amazon.com/sdkref/latest/guide/feature-container-credentials.html))
   
   ### Does this PR introduce _any_ user-facing change?
   
   yes, the `celeborn.storage.s3.secret.key` and 
`celeborn.storage.s3.access.key` are removed. In order to still provide those 
we should rely on the hadoop config (`celeborn.hadoop.fs.s3a.access.key` / 
`celeborn.hadoop.fs.s3a.secret.key `)
   
   ### How was this patch tested?
   
   Tested on celeborn cluster deployed on kubernetes and configured to use S3 
relying on `IAMInstanceCredentialsProvider`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to