FMX commented on code in PR #3243:
URL: https://github.com/apache/celeborn/pull/3243#discussion_r2078781996
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/TierWriterHelper.java:
##########
@@ -17,29 +17,24 @@
package org.apache.celeborn.service.deploy.worker.storage;
+import org.apache.hadoop.conf.Configuration;
+
import org.apache.celeborn.reflect.DynConstructors;
import org.apache.celeborn.server.common.service.mpu.MultipartUploadHandler;
public class TierWriterHelper {
public static MultipartUploadHandler getS3MultipartUploadHandler(
- String bucketName,
- String s3AccessKey,
- String s3SecretKey,
- String s3EndpointRegion,
- String key,
- int maxRetryies) {
+ Configuration conf, String bucketName, String key, int maxRetryies) {
return (MultipartUploadHandler)
DynConstructors.builder()
.impl(
"org.apache.celeborn.S3MultipartUploadHandler",
- String.class,
- String.class,
- String.class,
+ Configuration.class,
Review Comment:
Pass the Hadoop file system instance here, and you won't need to modify the
worker's pom file.
##########
worker/pom.xml:
##########
@@ -143,6 +143,42 @@
</build>
<profiles>
+
+ <profile>
Review Comment:
Looks like these changes are not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
