gauravkm commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2104731990
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -1011,6 +1043,12 @@ public int pushOrMergeData(
// increment batchId
final int nextBatchId = pushState.nextBatchId();
+ // Track commit metadata if shuffle compression and integrity check are
enabled and this request
+ // is not for pushing metadata itself.
+ if (shuffleCompressionEnabled && shuffleIntegrityCheckEnabled) {
Review Comment:
Is your question whether `shuffleIntegrityCheck` can be enabled without
enabling compression?
1. `shuffleIntegrityCheckEnabled` is for enabling/disabling integrity checks
on a per app basis
2. Shuffle Compression being enabled is not strictly required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
