zaynt4606 commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2113104329
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5471,6 +5472,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(false)
+ val CLIENT_SHUFFLE_INTEGRITY_CHECK_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.client.shuffle.integrityCheck.enabled")
+ .categories("client", "shuffle")
+ .version("0.5.0")
Review Comment:
```suggestion
.version("0.6.0")
```
##########
common/src/main/java/org/apache/celeborn/common/write/PushState.java:
##########
@@ -33,6 +34,8 @@ public class PushState {
private final int pushBufferMaxSize;
public AtomicReference<IOException> exception = new AtomicReference<>();
private final InFlightRequestTracker inFlightRequestTracker;
+ private final ConcurrentHashMap<Integer, CommitMetadata> commitMetadataMap =
Review Comment:
```suggestion
// partition id -> CommitMetadata
private final ConcurrentHashMap<Integer, CommitMetadata> commitMetadataMap
=
```
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -201,8 +208,10 @@ private static final class CelebornInputStreamImpl extends
CelebornInputStream {
private final boolean rangeReadFilter;
private final boolean enabledReadLocalShuffle;
private final String localHostAddress;
+ private final Map<String, CommitMetadata> expectedCommitMetadataMap = new
HashMap<>();
Review Comment:
Not in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
