gauravkm commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2127728302
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -715,6 +734,41 @@ public synchronized void close() {
}
}
+ void validateIntegrity() throws IOException {
+ if (integrityChecked || !shuffleIntegrityCheckEnabled) {
+ return;
+ }
+
+ String key = Utils.makeReducerKey(shuffleId, partitionId);
+
+ if (readSkewPartitionWithoutMapRange) {
+ shuffleClient.reducerPartitionEnd(
+ shuffleId,
+ partitionId,
+ numberOfSubPartitions,
+ currentIndexOfSubPartition,
+ aggregatedActualCommitMetadata.getChecksum(),
+ aggregatedActualCommitMetadata.getBytes());
+ logger.info(
+ "reducerPartitionEnd successful for {}. actual CommitMetadata: {}",
+ key,
+ aggregatedActualCommitMetadata);
+ } else {
+ shuffleClient.reducerPartitionEnd(
+ shuffleId,
+ partitionId,
+ startMapIndex,
+ endMapIndex,
+ aggregatedActualCommitMetadata.getChecksum(),
+ aggregatedActualCommitMetadata.getBytes());
+ logger.info(
+ "reducerPartitionEnd successful for {}. actual CommitMetadata: {}",
+ key,
+ aggregatedActualCommitMetadata);
+ }
+ integrityChecked = true;
Review Comment:
Makes sense. Merging them
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -438,6 +456,22 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
throw new UnsupportedOperationException(s"Not support $partitionType
yet")
}
+ case pb: ReducerPartitionEnd =>
Review Comment:
Ack. Updating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
