gauravkm commented on code in PR #3261:
URL: https://github.com/apache/celeborn/pull/3261#discussion_r2125516716
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -647,6 +650,35 @@ public Tuple2<Integer, Boolean> getShuffleId(
});
}
+ @Override
+ public void reducerPartitionEnd(
+ int shuffleId,
+ int partitionId,
+ int startMapIndex,
+ int endMapIndex,
+ int crc32,
+ long bytesWritten)
+ throws IOException {
+ PbReducerPartitionEnd pbReducerPartitionEnd =
+ PbReducerPartitionEnd.newBuilder()
+ .setShuffleId(shuffleId)
+ .setPartitionId(partitionId)
+ .setStartMaxIndex(startMapIndex)
+ .setEndMapIndex(endMapIndex)
+ .setCrc32(crc32)
+ .setBytesWritten(bytesWritten)
+ .build();
+
+ PbReducerPartitionEndResponse pbReducerPartitionEndResponse =
+ lifecycleManagerRef.askSync(
+ pbReducerPartitionEnd,
+ conf.clientRpcRegisterShuffleAskTimeout(),
+ ClassTag$.MODULE$.apply(PbReducerPartitionEndResponse.class));
+ if (pbReducerPartitionEndResponse.getStatus() !=
StatusCode.SUCCESS.getValue()) {
Review Comment:
Looking at the code it seems like in CelebornInputStream, there is existing
handling for throwing `FetchFailedException` in case of exceptions during
`fillBuffer`.
So if I throw CelebornIOException directly (instead of wrapping in
`RuntimeException`) during `validateIntegrity`, it will end up hitting the
existing codepath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
