turboFei commented on code in PR #3346:
URL: https://github.com/apache/celeborn/pull/3346#discussion_r2167283184
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -627,6 +627,8 @@ abstract class AbstractSource(conf: CelebornConf, role:
String)
sum
}
+ // Do use this method to get metrics, because it will clear the timeMetrics
queue
+ // Do not use the LogReporter to report metrics
Review Comment:
Does it mean that, if we enable LoggerSink, the prometheus can not retrieve
timeMetrics then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
