turboFei commented on code in PR #3346:
URL: https://github.com/apache/celeborn/pull/3346#discussion_r2167729203
##########
common/src/main/scala/org/apache/celeborn/common/metrics/source/AbstractSource.scala:
##########
@@ -627,6 +627,8 @@ abstract class AbstractSource(conf: CelebornConf, role:
String)
sum
}
+ // Do use this method to get metrics, because it will clear the timeMetrics
queue
+ // Do not use the LogReporter to report metrics
Review Comment:
Seems the loggerSink is a safety measures to help cleanup the timeMetrics,
if the `getMetrics` is not called for long time.
For our use case, we have a sidecar agent to collect celeborn metrics
periodically, and we do not need to enable this feature.
could you highlight it in the ConfigEntry docs or migration guide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
