mridulm commented on code in PR #3248:
URL: https://github.com/apache/celeborn/pull/3248#discussion_r2220269186
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1048,13 +1048,26 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
context.reply(pbGetShuffleIdResponse)
case None =>
- val pbGetShuffleIdResponse = {
- logInfo(
- s"there is no finished map stage associated with appShuffleId
$appShuffleId")
-
PbGetShuffleIdResponse.newBuilder().setShuffleId(UNKNOWN_APP_SHUFFLE_ID).setSuccess(
- false).build()
+ // If no valid finished map stage is found, check if there are any
shuffles
+ shuffleIds.values.map(v => v._1).toSeq.reverse.headOption match {
+ case Some(celebornShuffleId) =>
+ val pbGetShuffleIdResponse = {
+ logInfo(
+ s"No finished map stage found, using latest shuffleId
$celebornShuffleId for appShuffleId $appShuffleId appShuffleIdentifier
$appShuffleIdentifier isWriter $isWriter")
+
PbGetShuffleIdResponse.newBuilder().setShuffleId(celebornShuffleId).setSuccess(
+ true).build()
+ }
+ context.reply(pbGetShuffleIdResponse)
+ case None =>
+ val pbGetShuffleIdResponse = {
+ logInfo(
+ s"there is no finished map stage associated with
appShuffleId $appShuffleId")
+ PbGetShuffleIdResponse.newBuilder().setShuffleId(
+ UNKNOWN_APP_SHUFFLE_ID).setSuccess(
+ false).build()
+ }
+ context.reply(pbGetShuffleIdResponse)
Review Comment:
Is this related to the current PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
