SteNicholas commented on code in PR #3248:
URL: https://github.com/apache/celeborn/pull/3248#discussion_r2221230807
##########
common/src/main/java/org/apache/celeborn/common/write/InFlightRequestTracker.java:
##########
@@ -110,6 +140,11 @@ public boolean limitMaxInFlight(String hostAndPushPort)
throws IOException {
&& batchIdSet.size() <= currentMaxReqsInFlight) {
break;
}
+ if (maxInFlightBytesSizeInFlightEnabled
+ && (totalInflightBytes.sum() <= maxInFlightBytesSizeInFlightTotal
+ && batchBytesSize <= maxInFlightBytesSizeInFlightPerWorker))
{
Review Comment:
@mridulm, this should be `||` because the condition requires that
`inflightBytes` is within the `maxInFlightBytesSizeTotal` and
`maxInFlightBytesSizePerWorker`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
