mridulm commented on code in PR #3487:
URL: https://github.com/apache/celeborn/pull/3487#discussion_r2366374247
##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -391,8 +405,9 @@ class ReducePartitionCommitHandler(
shuffleMapperAttempts.synchronized {
if (!shuffleMapperAttempts.containsKey(shuffleId)) {
val attempts = new Array[Int](numMappers)
- 0 until numMappers foreach (idx => attempts(idx) = -1)
+ util.Arrays.fill(attempts, -1)
Review Comment:
`Arrays.fill` is faster than the `foreach` - while not the focus of this PR,
included it when I observed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
