pan3793 commented on code in PR #3487: URL: https://github.com/apache/celeborn/pull/3487#discussion_r2368761221
########## client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala: ########## @@ -75,6 +75,7 @@ class ReducePartitionCommitHandler( private val stageEndShuffleSet = ConcurrentHashMap.newKeySet[Int]() private val inProcessStageEndShuffleSet = ConcurrentHashMap.newKeySet[Int]() private val shuffleMapperAttempts = JavaUtils.newConcurrentHashMap[Int, Array[Int]]() + private val shuffleToCompletedMappers = JavaUtils.newConcurrentHashMap[Int, Int]() Review Comment: millions of key-value pairs take dozens of MiB memory, not sure if worth using `fastutil`-like optimization, which is more memory-friendly for primitive types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
