leixm opened a new pull request, #3531: URL: https://github.com/apache/celeborn/pull/3531
### What changes were proposed in this pull request? Fix fetch fail not throw due to reach spark maxTaskFailures. ### Why are the changes needed? The condition `ti.attemptNumber() >= maxTaskFails - 1` may not be executed. Suppose that the current `taskAttempts` is index0, index1, index2, and index3, and that index0 and index1 have already failed while index2 and index3 are running, and the current `reportFetchFailed` is index3, then the final result will be false, while the expected result will be true. Therefore, we should check the attemptNumber of the current task separately before the loop starts. ### Does this PR resolve a correctness bug? No. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
