SteNicholas commented on code in PR #3531:
URL: https://github.com/apache/celeborn/pull/3531#discussion_r2533876219
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java:
##########
@@ -362,22 +365,41 @@ public static boolean
shouldReportShuffleFetchFailure(long taskId) {
taskId,
taskInfo.attemptNumber(),
ti.attemptNumber());
- return false;
- }
- } else {
- if (ti.attemptNumber() >= maxTaskFails - 1) {
- logger.warn(
- "StageId={} index={} taskId={} attemptNumber {} reach
maxTaskFails {}.",
+ hasRunningAttempt = true;
+ } else if (ti.status() == "FAILED" || ti.status() == "UNKNOWN") {
Review Comment:
```suggestion
} else if ("FAILED".equals(ti.status()) ||
"UNKNOWN".equals(ti.status())) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
