pingzh opened a new pull request, #3535:
URL: https://github.com/apache/celeborn/pull/3535
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
- add the `checksum/celeborn_config` annotation to both worker and master's
statefulset:
```
annotations:
checksum/celeborn_config:
0a0d909a0539b19a6b70f6a8df315a22eb12b5b4c3f59457d93b10405ae685f6
```
- sort the keys of celeborn config in the config map to produce consistent
checksum
### Why are the changes needed?
so that when the configs in `celeborn` are changed, helm can restart the
celeborn service
### Does this PR resolve a correctness bug?
<!-- Yes/No. (Note: If yes, committer will add `correctness` label to
current pull request). -->
No
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
1. helm unittest
```
~/Documents/repos/opensource/celeborn/charts/celeborn
❯ helm unittest . --file "tests/**/*_test.yaml" --strict --debug
### Chart [ celeborn ] .
PASS Test Celeborn configmap tests/configmap_test.yaml
PASS Test Celeborn role tests/role_test.yaml
PASS Test Celeborn rolebinding tests/rolebinding_test.yaml
PASS Test Celeborn service account tests/serviceaccount_test.yaml
PASS Test Celeborn master pod monitor
tests/master/podmonitor_test.yaml
PASS Test Celeborn master priority class
tests/master/priorityclass_test.yaml
PASS Test Celeborn master service tests/master/service_test.yaml
PASS Test Celeborn master statefulset
tests/master/statefulset_test.yaml
PASS Test Celeborn worker pod monitor
tests/worker/podmonitor_test.yaml
PASS Test Celeborn worker priority class
tests/worker/priorityclass_test.yaml
PASS Test Celeborn worker service tests/worker/service_test.yaml
PASS Test Celeborn worker statefulset
tests/worker/statefulset_test.yaml
Charts: 1 passed, 1 total
Test Suites: 12 passed, 12 total
Tests: 75 passed, 75 total
Snapshot: 0 passed, 0 total
Time: 107.537875ms
```
2. `helm template --debug ../celeborn`
<img width="2312" height="1178" alt="image"
src="https://github.com/user-attachments/assets/b6d204b7-b2fc-4fd5-b00e-3b353f338a8e";
/>
<img width="2532" height="1430" alt="image"
src="https://github.com/user-attachments/assets/74f0b495-88a1-404f-ba09-647b1c306a69";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
