ChenYi015 commented on code in PR #3535:
URL: https://github.com/apache/celeborn/pull/3535#discussion_r2508944695
##########
charts/celeborn/templates/master/statefulset.yaml:
##########
@@ -37,10 +37,12 @@ spec:
labels:
{{- include "celeborn.master.selectorLabels" . | nindent 8 }}
app.kubernetes.io/tag: {{ .Values.image.tag | quote }}
- {{- with .Values.master.annotations }}
annotations:
- {{- toYaml . | nindent 8 }}
- {{- end }}
+ {{- $annotations := dict "checksum/celeborn_config" (include
"celeborn.configChecksum" .) -}}
Review Comment:
I prefer annotation key which prefixes with organzation domain here,
like`celeborn.apache.org/conf-hash`, as this is more common in Kubernetes
components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
