turboFei commented on code in PR #3531:
URL: https://github.com/apache/celeborn/pull/3531#discussion_r2536593712
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java:
##########
@@ -335,16 +335,19 @@ public static boolean
shouldReportShuffleFetchFailure(long taskId) {
if (taskAttempts == null) return true;
TaskInfo taskInfo = taskAttempts._1();
+ int failedTaskAttempts = 1;
+ boolean hasRunningAttempt = false;
for (TaskInfo ti : taskAttempts._2()) {
if (ti.taskId() != taskId) {
if (reportedStageTaskIds.contains(ti.taskId())) {
logger.info(
- "StageId={} index={} taskId={} attempt={} another attempt {}
has reported shuffle fetch failure, ignore it.",
+ "StageId={} index={} taskId={} attempt={} another attempt {}
has reported shuffle fetch failure.",
stageId,
taskInfo.index(),
taskId,
taskInfo.attemptNumber(),
ti.attemptNumber());
+ return true;
Review Comment:
It was false before.
https://github.com/apache/celeborn/blob/3d61cede3f42155e3f895c52acc30e069655b77c/client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java#L413-L420
```
Other attempts already reported shuffle fetch failures for the same task
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
