RexXiong commented on code in PR #3562:
URL: https://github.com/apache/celeborn/pull/3562#discussion_r2617043647
##########
common/src/main/java/org/apache/celeborn/common/meta/DiskFileInfo.java:
##########
@@ -150,19 +150,21 @@ public void setMountPoint(String mountPoint) {
}
public boolean isHdfs() {
- return Utils.isHdfsPath(filePath);
+ return storageType == StorageInfo.Type.HDFS;
Review Comment:
The current implementation of DiskFileInfo does not serialize the storage
type information. As a result, when a worker recovers from a graceful shutdown,
the storage type in DiskFileInfo defaults to StorageInfo.Type.HDD. This
behavior can cause the method isDFS to return incorrect results due to the
default assumption of the storage type as HDD. Maybe we should serialize
storage type info first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
