ErikFang commented on code in PR #3562:
URL: https://github.com/apache/celeborn/pull/3562#discussion_r2619022352
##########
common/src/main/java/org/apache/celeborn/common/meta/DiskFileInfo.java:
##########
@@ -150,19 +150,21 @@ public void setMountPoint(String mountPoint) {
}
public boolean isHdfs() {
- return Utils.isHdfsPath(filePath);
+ return storageType == StorageInfo.Type.HDFS;
Review Comment:
> Good point. Can we modify it to the following code?
>
> ```
> public boolean isHdfs() {
> return storageType == StorageInfo.Type.HDFS ||
Utils.isHdfsPath(filePath);
> }
> ```
I don't think this is a good idea, let's add storage type into serialized
data instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
