HolyLow commented on code in PR #3568:
URL: https://github.com/apache/celeborn/pull/3568#discussion_r2639093828
##########
cpp/celeborn/client/writer/PushState.cpp:
##########
@@ -147,9 +215,18 @@ std::optional<std::string> PushState::getExceptionMsg()
const {
}
void PushState::cleanup() {
+ LOG(INFO) << "Cleanup " << totalInflightReqs_.load() << " requests in
flight.";
+ cleaned_ = true;
inflightBatchesPerAddress_.clear();
totalInflightReqs_ = 0;
pushStrategy_->clear();
+
+ if (maxInFlightBytesSizeEnabled_) {
+ LOG(INFO) << "Cleanup " << totalInflightBytes_.load() << " bytes in
flight.";
Review Comment:
Pls do not use LOG(INFO) here which is too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
