HolyLow commented on code in PR #3568:
URL: https://github.com/apache/celeborn/pull/3568#discussion_r2639104815
##########
cpp/celeborn/client/tests/PushStateTest.cpp:
##########
@@ -46,6 +46,45 @@ class PushStateTest : public testing::Test {
static constexpr int pushTimeoutMs_ = 100;
static constexpr int pushSleepDeltaMs_ = 10;
static constexpr int maxReqsInFlight_ = 2;
+ static constexpr int defaultBatchSize_ = 1024;
+};
+
+class PushStateBytesSizeTest : public testing::Test {
+ protected:
+ void SetUp() override {
+ conf::CelebornConf conf;
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushLimitInFlightTimeoutMs,
+ std::to_string(pushTimeoutMs_));
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushLimitInFlightSleepDeltaMs,
+ std::to_string(pushSleepDeltaMs_));
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushMaxReqsInFlightTotal, "100");
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushMaxReqsInFlightPerWorker, "100");
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushMaxBytesSizeInFlightEnabled, "true");
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushMaxBytesSizeInFlightTotal,
+ std::to_string(maxBytesSizeTotal_));
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushMaxBytesSizeInFlightPerWorker,
+ std::to_string(maxBytesSizePerWorker_));
+ conf.registerProperty(
+ conf::CelebornConf::kClientPushBufferMaxSize,
+ std::to_string(bufferMaxSize_));
+
+ pushState_ = std::make_unique<PushState>(conf);
+ }
+
+ std::unique_ptr<PushState> pushState_;
+ static constexpr int pushTimeoutMs_ = 100;
Review Comment:
It might be more consistent if we change the naming of static constexpr
namings to kXxxXxx_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
