SteNicholas commented on code in PR #3562:
URL: https://github.com/apache/celeborn/pull/3562#discussion_r2645233705
##########
common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala:
##########
@@ -51,6 +51,9 @@ class PbSerDeUtilsTest extends CelebornFunSuite {
val file1 = new File("/mnt/disk/1")
val file2 = new File("/mnt/disk/2")
+ val file3 = "hdfs://xxx:9000/xxxx/xx-xx/x-x-x"
+ val file4 = "oss://xxxx/xx-xx/x-x-x"
+ val file5 = "s3a://xxxx/xx-xx/x-x-x"
Review Comment:
Please add the test case for the prefix `s3://`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
