afterincomparableyum commented on code in PR #3568:
URL: https://github.com/apache/celeborn/pull/3568#discussion_r2647140768
##########
cpp/celeborn/conf/CelebornConf.cpp:
##########
@@ -162,6 +162,10 @@ CelebornConf::defaultProperties() {
kShuffleCompressionCodec,
protocol::toString(protocol::CompressionCodec::NONE)),
NUM_PROP(kShuffleCompressionZstdCompressLevel, 1),
+ STR_PROP(kClientPushBufferMaxSize, "64k"),
+ BOOL_PROP(kClientPushMaxBytesSizeInFlightEnabled, false),
+ NONE_PROP(kClientPushMaxBytesSizeInFlightTotal),
Review Comment:
my understanding is that NONE_PROP is correct. It matches Java's
.createOptional behavior.
the property is optional, and the default is computed dynamically when not
set.
Do you believe it should be something else other than NONE_PROP? I feel like
NONE_PROP is good because these parameters are optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
