afterincomparableyum commented on code in PR #3568:
URL: https://github.com/apache/celeborn/pull/3568#discussion_r2647138332
##########
cpp/celeborn/conf/CelebornConf.cpp:
##########
@@ -267,6 +271,41 @@ long CelebornConf::clientPushLimitInFlightSleepDeltaMs()
const {
optionalProperty(kClientPushLimitInFlightSleepDeltaMs).value());
}
+int CelebornConf::clientPushBufferMaxSize() const {
+ return toCapacity(
+ optionalProperty(kClientPushBufferMaxSize).value(), CapacityUnit::BYTE);
+}
+
+bool CelebornConf::clientPushMaxBytesSizeInFlightEnabled() const {
+ return optionalProperty(kClientPushMaxBytesSizeInFlightEnabled).value() ==
+ "true";
+}
+
+long CelebornConf::clientPushMaxBytesSizeInFlightTotal() const {
+ auto optionalValue = optionalProperty(kClientPushMaxBytesSizeInFlightTotal);
+ long maxBytesSizeInFlight =
+ optionalValue.has_value() ? toCapacity(optionalValue.value(),
CapacityUnit::BYTE) : 0L;
+ if (clientPushMaxBytesSizeInFlightEnabled() && maxBytesSizeInFlight > 0L) {
+ return maxBytesSizeInFlight;
+ }
+ // Default: maxReqsInFlightTotal * bufferMaxSize
+ return static_cast<long>(clientPushMaxReqsInFlightTotal()) *
+ clientPushBufferMaxSize();
+}
+
+long CelebornConf::clientPushMaxBytesSizeInFlightPerWorker() const {
+ auto optionalValue =
+ optionalProperty(kClientPushMaxBytesSizeInFlightPerWorker);
+ long maxBytesSizeInFlight =
Review Comment:
any suggestions for how to simplify it @HolyLow ? I see in the java client,
this is how the function is:
```
def clientPushMaxBytesSizeInFlightPerWorker: Long = {
val maxBytesSizeInFlight =
get(CLIENT_PUSH_MAX_BYTES_SIZE_IN_FLIGHT_PERWORKER).getOrElse(0L)
if (clientPushMaxBytesSizeInFlightEnabled && maxBytesSizeInFlight > 0L) {
maxBytesSizeInFlight
} else {
clientPushMaxReqsInFlightPerWorker * clientPushBufferMaxSize
}
}
```
The logic is similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
