RexXiong commented on code in PR #3586:
URL: https://github.com/apache/celeborn/pull/3586#discussion_r2730828888


##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -77,6 +77,8 @@ class ReducePartitionCommitHandler(
   private val shuffleMapperAttempts = JavaUtils.newConcurrentHashMap[Int, 
Array[Int]]()
   // TODO: Move this to native Int -> Int Map
   private val shuffleToCompletedMappers = JavaUtils.newConcurrentHashMap[Int, 
Int]()
+  private val shuffleIdLocks = JavaUtils.newConcurrentHashMap[Int, Object]()

Review Comment:
   Better remove the lock object when the shuffle expired.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to