yew1eb commented on code in PR #3586:
URL: https://github.com/apache/celeborn/pull/3586#discussion_r2731754354
##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -314,7 +317,8 @@ class ReducePartitionCommitHandler(
numPartitions: Int,
crc32PerPartition: Array[Int],
bytesWrittenPerPartition: Array[Long]): (Boolean, Boolean) = {
- val (mapperAttemptFinishedSuccess, allMapperFinished) =
shuffleMapperAttempts.synchronized {
+ val shuffleLock = shuffleIdLocks.computeIfAbsent(shuffleId, _ => new
Object())
Review Comment:
updated
##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -428,7 +432,8 @@ class ReducePartitionCommitHandler(
}
private def initMapperAttempts(shuffleId: Int, numMappers: Int,
numPartitions: Int): Unit = {
- shuffleMapperAttempts.synchronized {
+ val shuffleLock = shuffleIdLocks.computeIfAbsent(shuffleId, _ => new
Object())
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
