RexXiong commented on code in PR #3590:
URL: https://github.com/apache/celeborn/pull/3590#discussion_r2732127153
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1522,7 +1522,31 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
shuffleKey: String,
index: Int): Unit = {
try {
- fileWriter.write(body)
+ val (endedAttempt, toWrite, curMapId, curMapAttempt) =
Review Comment:
Celeborn already check that otherMapAttempt is completed before executing
writeData to avoid unnecessary writes. Why is it necessary to perform an
additional check within writeData to skip data writing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
