RexXiong commented on code in PR #3590:
URL: https://github.com/apache/celeborn/pull/3590#discussion_r2766859338
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1522,7 +1522,31 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
shuffleKey: String,
index: Int): Unit = {
try {
- fileWriter.write(body)
+ val (endedAttempt, toWrite, curMapId, curMapAttempt) =
Review Comment:
Thanks, you're correct. Previously, the mapper end check was performed only
when the partition location was null during the handling of
PushData/PushMergeData. I believe we can enhance this by extending the check to
the mapper level, regardless of whether the partition location is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
